Fix 'all armor stands' expression not working #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
approved these changes
Aug 9, 2021
|
This PR also fixes missing and/or warning showing up when they were disabled in config (#2370), and I also fixed another bug with ParseLogHandlers that caused warnings in list parsing not to show up |
TPGamesNL
added a commit
to TPGamesNL/Skript
that referenced
this pull request
Mar 8, 2022
(cherry picked from commit d707c15)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug was caused by 4dc285a, as bensku said:
Because of this code in SkriptParser, it tries to parse
all armor standsas an ItemType first. This works, becauseall ...is a valid pattern for items (e.g.all beds, all flowers): you can even useall ...for any item, not just items that have multiple possibilities.Disabling this code would originally break syntax such as
diamond sword of sharpness and unbreakingor2 minutes and 5 seconds, because Skript tries to parse it as a list (e.g.diamond sword of sharpnessandunbreaking), but this bug is fixed by #4242.#4242 must be merged before this PR
This decreases the parsing time of my test scripts by 9%
Target Minecraft Versions: any
Requirements: none
Related Issues: #2370, #2723, #4239, #4242