Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function name to nonexistent function call error #3978

Merged
merged 6 commits into from
Jun 9, 2021
Merged

Add function name to nonexistent function call error #3978

merged 6 commits into from
Jun 9, 2021

Conversation

TPGamesNL
Copy link
Member

Description

Adds the function name to the error.

Test code:

# Script 1.sk
on load:
	broadcast "1"
	doStuff()
	broadcast "3"

# Script 2.sk
function doStuff():
	broadcast "2"

Current:
image
With changes:
image

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.5 labels May 10, 2021
@TPGamesNL TPGamesNL requested a review from ShaneBeee May 10, 2021 15:00
ShaneBeee
ShaneBeee approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

TPGamesNL and others added 3 commits May 10, 2021 18:58
@TPGamesNL TPGamesNL closed this May 13, 2021
@TPGamesNL TPGamesNL deleted the fix/missing-function-error branch May 13, 2021 16:51
@TPGamesNL TPGamesNL restored the fix/missing-function-error branch May 13, 2021 16:52
@TPGamesNL TPGamesNL reopened this May 13, 2021
@APickledWalrus APickledWalrus merged commit e9d15bd into SkriptLang:master Jun 9, 2021
@TPGamesNL TPGamesNL deleted the fix/missing-function-error branch June 10, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranKusmiruk FranKusmiruk FranKusmiruk left review comments

@ShaneBeee ShaneBeee ShaneBeee approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TPGamesNL @ShaneBeee @APickledWalrus @FranKusmiruk