EvtMove - new player/entity move event #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
requested changes
May 9, 2021
FranKusmiruk
reviewed
May 9, 2021
TPGamesNL
reviewed
May 9, 2021
APickledWalrus
requested changes
May 9, 2021
APickledWalrus
approved these changes
May 9, 2021
FranKusmiruk
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Player move event, along with an entity move event.
In the past it has been discussed to not use these events as they are performance heavy.
Here are a couple reasons I decided to add this:
Skript already uses the move event for the "move on" event. So regardless, the performance is going to be hindered by that event.
Paper (and I think Spigot too) only calls heavy events like this, if a plugin actually registers an event.
Skript only registers a listener if a user is using said event. That said, performance will only potentially take a hit to users who use this event. I added cautionary notes in the description of the event to make sure users are clear. This is up to them if they want to use the event or not.
I don't think its in our position to deny users an event strictly because we think it may hurt their server, we should leave that decision in their hands. SkQuery already has this event, which is used by many people. I figured its probably in our best interest to add it.
Target Minecraft Versions: Paper 1.16.5+ for entity move, any for player move
Requirements: Paper 1.16.5+ for entity move, any for player move
Related Issues: #716 (added by pickle man)