Handle cancellation of ServerCommandEvent properly #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ServerCommandEvent was made Cancellable somewhere between 1.8 and 1.8.8 but not respected on Skript Since EffCancelEvent checks for Cancellable as interface, it worked, but some other places on Skript checked manually that if ServerCommandEvent is cancelled by determining if the command is empty or not. Related Spigot commit: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/c31fcfe3a19c4ee597df75e750af1542ac020b92
APickledWalrus
approved these changes
Mar 1, 2021
Whimsyturtle
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ServerCommandEvent was made Cancellable somewhere between 1.8 and 1.8.8 but not respected on Skript
Since EffCancelEvent checks for Cancellable as interface, it worked, but some other places on Skript checked manually that if ServerCommandEvent is cancelled by determining if the command is empty or not.
Related Spigot commit:
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/c31fcfe3a19c4ee597df75e750af1542ac020b92
Target Minecraft Versions: any
Requirements: none
Related Issues: none