NewBlockCompat - fix issue with bisected blocks alternatively placing #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By not cloning the data, the original data is set to the opposing state (up/down), therefor placing the next block starts with the opposing state
APickledWalrus
previously approved these changes
Mar 1, 2021
The base branch was changed.
Whimsyturtle
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting a block to a bisected block (such as a door or bed), it will alternate the bisection.
ie: set a block to a door, it sets correctly. Repeat that task, and it will set at the block below. This is caused by Skript changing the ItemType's ItemData to the opposing bisection, causing blocks to alternate.
By cloning the original data, we don't have to change it.
Target Minecraft Versions: 1.13+
Requirements: None
Related Issues: #2473