Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprRawName - fix an error from the toString method #3693

Merged
merged 1 commit into from
Mar 21, 2021
Merged

ExprRawName - fix an error from the toString method #3693

merged 1 commit into from
Mar 21, 2021

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to fix an NPE error when using this expression in a string, ie:

send "%minecraft name of player's tool%"

should return

[02:49:08 WARN]: [Skript] minecraft name of the tool of the player is already a text, so you should not put it in one (e.g. minecraft name of the tool of the player instead of "%minecraft name of the tool of the player%") (test.sk, line 6: send "%minecraft name of player's tool%"')

but instead its throwing an error.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.5 labels Jan 14, 2021
APickledWalrus
APickledWalrus previously approved these changes Mar 1, 2021
@Whimsyturtle Whimsyturtle changed the base branch from dev-2.5 to master March 21, 2021 00:24
@Whimsyturtle Whimsyturtle dismissed APickledWalrus’s stale review March 21, 2021 00:24

The base branch was changed.

@Whimsyturtle Whimsyturtle merged commit 9a6179b into SkriptLang:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants