Rework function system #2383
Merged
Rework function system #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary data from signatures.
…. General function system cleanup.
…but opens possibilities in future.
|
What about #2188 |
|
Maybe you could change the error message to "none is given" instead of "but 0 are given" when the function doesn't have enough arguments. |
|
What about #2345 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains a rework of Skript's function system.
More testing will be needed before this can be merged.
Target Minecraft Versions: any
Requirements: none
Related Issues: #2337, #2378 and potentially other function-related issues