Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grow %tree type% above %location% doesn't work with trees other than oak and spruce :V #494

Closed
PoweredDragon opened this issue Apr 12, 2017 · 4 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@PoweredDragon
Copy link

PoweredDragon commented Apr 12, 2017

Hi. Got a problem with this script:

on sneak toggle:
	chance of 10%:
		loop blocks in radius 5 of player:
			set {_l} to location of loop-block
			loop-block is sapling:0:
				set loop-block to air
				grow oak above {_l}
			loop-block is sapling:1:
				set loop-block to air
				grow spruce above {_l}
			loop-block is sapling:2:
				set loop-block to air
				grow birch above {_l}
			loop-block is sapling:3:
				set loop-block to air
				grow jungle above {_l}
			loop-block is sapling:4:
				set loop-block to air
				grow acacia above {_l}
			loop-block is sapling:5:
				set loop-block to air
				grow dark oak above {_l}

Well; everything is ok with oak and spruce, but with birch, etc. it seems to fall apart:

[19:37:33 ERROR]: [Skript] Can't understand this condition/effect: grow birch above {_l} (tree.sk, line 13: grow birch above {_l}')
[19:37:33 ERROR]: [Skript] Can't understand this condition/effect: grow jungle above {_l} (tree.sk, line 16: grow jungle above {_l}')
[19:37:33 ERROR]: [Skript] Can't understand this condition/effect: grow acacia above {_l} (tree.sk, line 19: grow acacia above {_l}')
[19:37:33 ERROR]: [Skript] Can't understand this condition/effect: grow dark oak above {_l} (tree.sk, line 22: grow dark oak above {_l}')

It all seems to doesn't work on the newest Sk version :v

@Snow-Pyon
Copy link

Because birch, jungle, acacia​ and dark oak aren't a tree type, try with the following:

[any ] tree[s]

[any ](regular tree|normal tree|oak)[s]

small (regular tree|normal tree|oak)[s]

(big|large) (regular tree|normal tree|oak)[s]

[any ](fir|pine|spruce|redwood)[s]

small (fir|pine|spruce|redwood)[s]

(big|tall) (fir|pine|spruce|redwood)[s]

[any ]jungle tree[s]

small jungle tree[s]

(big|tall|huge|giant|large) jungle tree[s]

[jungle ]bush[es]

swamp tree[s]

[any ](huge|giant|large|big) mushroom[s]

(huge|giant|large|big) red mushroom[s]

(huge|giant|large|big) brown mushroom[s]

From the English.lang file, although I don't see the 1.8 trees nor the birch tree there, you might add them @bensku

@bensku bensku added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 13, 2017
@PoweredDragon
Copy link
Author

PoweredDragon commented Apr 13, 2017

My aliases file:

{tree type}:
{default} = :0-15
(normal|regular|oak) = :0, :4, :8, :12
(pine|redwood|fir|spruce) = :1, :5, :9, :13
birch = :2, :6, :10, :14
jungle = :3, :7, :11, :15
{tree type 2}:
{default} = :0-15
acacia = :0, :4, :8, :12, :2, :6, :10, :14
dark oak = :1, :5, :9, :13, :3, :7, :11, :15
{wood type}:
{default} = :0-5
= :0-5
(oak|regular|normal) = :0
(spruce|fir|redwood|pine) = :1
birch = :2
jungle = :3
acacia = :4
dark oak = :5

Neither "small jungle tree" works (i tried it too)
@bensku

@Snow-Pyon
Copy link

@PoweredDragon the aliases file is only for the item aliases, not the tree types. The aliases of the tree types and other types are in the English.lang file which is in the lang folder (not accessible via the Skript folder yet but you can found it into the Skript.jar)

bensku added a commit that referenced this issue Apr 15, 2017
@bensku
Copy link
Member

bensku commented Apr 15, 2017

That was actually quite easy to do.

@bensku bensku closed this as completed Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

3 participants