Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressions with embedded quotes no longer parse #485

Closed
TheBentoBox opened this issue Apr 10, 2017 · 1 comment
Closed

Expressions with embedded quotes no longer parse #485

TheBentoBox opened this issue Apr 10, 2017 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@TheBentoBox
Copy link
Member

Hello

Sorry if the title isn't worded amazingly, I'm not sure how best to put it.

Example Test

Here's an example of me trying to get Skript to send me my stringified player object in dev26 (this should print out my name):

image

For the sake of showing how it should work, here's a test run in dev25 immediately afterwards (stopped server, replaced the jar with dev25, started again, no other changes):

image

Unlike the other issues I've reported, this is not just an issue within chat messages. Even if I run, for example, set player's tool's name to "%""Mr_Simba"" parsed as player%", it will give the same error. This is not the case in dev25 or below, where it will work as expected based on the second screenshot.

Also, I know this example seems poor, but it's the first thing I thought of on the spot to demonstrate the issue. Especially when using addons, needing to stringify expressions with text within them is pretty common. One common example for my server is when using SkStuff, which has the expression tag %text% of NBT of %entity%. If I want to compare the returned NBT tag to a string (which I do a lot), I could run if "%tag ""Example"" of NBT of player%" is "1". This no longer parses in dev26, which results in dozens of errors when loading all of my scripts (which work fine and parse correctly on dev25). In the case of that SkStuff expression, Skript fails at parsing it and says that the tag is not a world.

Setup

  • Spigot-d276ab1-1f6c04c for 1.11.2 (1 version behind latest)
  • Skript dev26c
  • No addons, no scripts loaded
  • Setup screenshot
@TheBentoBox TheBentoBox added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 10, 2017
@TheBentoBox TheBentoBox changed the title Quotes embedded in expressions no longer parse the expression correctly Expressions with embedded quotes no longer parse Apr 10, 2017
@bensku
Copy link
Member

bensku commented Apr 11, 2017

Fixed with next release. There was actually two bugs with quotes, one specific to JSON chat and one that appeared everywhere (both fixed).

@bensku bensku closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

2 participants