Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some of on rightclick event does not work when offhand tool is a shield #385

Closed
ghost opened this issue Feb 14, 2017 · 4 comments
Closed
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@ghost
Copy link

ghost commented Feb 14, 2017

The script below works well basically, but under particular situation below, it doesn't work.
-If player's offhand tool is shield
-and player's main hand tool is seeds (of wheet, pumpkin, melon and beetloot)
-and player's target block is farmland
(It means potato and carrot works well)

I guess the cause is about offhand shield.. but I don't know how to fix.
I would appreciate if you fix the problem or tell me how to avoid this problem. Thank you.

aliases:
	seeds = 295, 351:3, 361, 362, 372, 391, 392, 435
*all kinds of seeds, carrot item, and potatoes and so on

on rightclick holding seeds:
	message "test"
@TheBentoBox TheBentoBox added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 16, 2017
@TheBentoBox
Copy link
Member

This sounds like an issue for bensku to consider, but just as a possible solution for you, you could try using an on place event instead, where it detects the placement of the crop blocks instead of right clicking with them. (Though I suppose you may not be trying to detect planting).

@Syst3ms
Copy link
Contributor

Syst3ms commented Feb 17, 2017

Or even better, on can build check

@bensku
Copy link
Member

bensku commented Feb 18, 2017

Apparently Skript treated holding exactly same as with, while they can mean different things now that we have offhand support.

This means I had not to deal with weird event-firing-twice stuff. Easy to fix.

Edit: I just realized that I have a ton of other stuff to do... You were quite lucky that I happened to fix this that fast :)

@ghost
Copy link
Author

ghost commented Feb 18, 2017

Thanks for your commit and considerate comment.
and thanks for The Bento Box's and Syst3ms's kindful help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

3 participants