Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: inherent support for "final damage" expression in damage events #135

Closed
TheBentoBox opened this issue Jul 18, 2016 · 2 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@TheBentoBox
Copy link
Member

The EntityDamageEvent has a getter method to get the final damage after all damage reduction, as event.getFinalDamage(). This is supported in RandomSK, but it hasn't been updated and doesn't even run on versions newer than 1.8 without being run through the SpecialSource fix. This is causing issues for a lot of unexperienced players who don't know how to run SpecialSource, and it would be an ideal expression to move straight into vanilla Skript.

@JavierKasunic
Copy link

JavierKasunic commented Jul 19, 2016

You can use:

last damage cause of %livingentities%

It's already from the dev10

Or:

last damage %living entity%
%living entity%'[s] last damage

last damage cause of %living entity%
%living entity%'[s] last damage cause

From TuSKe

@bensku
Copy link
Member

bensku commented Jul 20, 2016

Not bad idea, if it is simple to add.

@bensku bensku added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 20, 2016
bensku added a commit that referenced this issue Aug 14, 2016
@bensku bensku closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

3 participants