Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle exit event not triggering #133

Closed
samrvr opened this issue Jul 17, 2016 · 4 comments
Closed

Vehicle exit event not triggering #133

samrvr opened this issue Jul 17, 2016 · 4 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@samrvr
Copy link

samrvr commented Jul 17, 2016

on vehicle exit:
Cannot be understood by Skript. Has this been removed?

@JavierKasunic
Copy link

JavierKasunic commented Jul 18, 2016

I can confirm this. Also I checked the SimpleEvents.class and it's not registered. @bensku only need register it.

Or maybe he replaced this event with the [on] entity (mount|dismount) event. This is after the dev-13b

Also if you add the [on] vehicle (steer|button press) event would be amazing.

@bensku
Copy link
Member

bensku commented Jul 19, 2016

This is not a bug, instead it is caused by certain interesting decisions in Spigot API. Only entities player can normally (in vanilla) ride are counted as vehicles. This includes pigs, horses, boats and minecarts currently.

For other entities, mount/dismount should work. On Skript's side, code is quite similar, it just takes different Spigot events in.

@bensku bensku added the invalid Not a Skript issue, already implemented, does not apply, etc. label Jul 19, 2016
@bensku bensku closed this as completed Jul 19, 2016
@bensku bensku removed the invalid Not a Skript issue, already implemented, does not apply, etc. label Jul 19, 2016
@bensku
Copy link
Member

bensku commented Jul 19, 2016

Wait a sec. This event doesn't exist. That's wrong, it should work for legacy scripts.

@bensku bensku reopened this Jul 19, 2016
@bensku bensku added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 19, 2016
@JavierKasunic
Copy link

That is what I mean on my above comment 😅

bensku added a commit that referenced this issue Jul 28, 2016
@bensku bensku closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

3 participants