Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on rightclick on villager (bug) #131

Closed
netherstar opened this issue Jul 15, 2016 · 10 comments
Closed

on rightclick on villager (bug) #131

netherstar opened this issue Jul 15, 2016 · 10 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@netherstar
Copy link

i have skript like this:

on right click on a villager:
    message "&cVillager trade is disable" to the player
    cancel event  

but, player can by pass by hold something in left-hand (1,9 feature, press F)

@bensku bensku added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 16, 2016
@bensku
Copy link
Member

bensku commented Jul 16, 2016

Oops, I thought I had fixed this.

@netherstar
Copy link
Author

netherstar commented Jul 17, 2016

and this skript:

#4 Anti Spawner Change via Egg
on rightclick on a monster spawner:
    player's tool is a spawn egg
    cancel event

player can by pass = hold spawn egg, press F, left click to spawner

@netherstar
Copy link
Author

and this skript won't work:

on right click on a armor stand:
    cancel event

pkayer still can put item in to armor stand

@bensku
Copy link
Member

bensku commented Jul 17, 2016

The last one is just lacking armor stand support, not really bug. Others are bugs indeed, and need fixing soon.

@netherstar
Copy link
Author

Do you have plan to support armor stand? please support it.

@JavierKasunic
Copy link

JavierKasunic commented Jul 17, 2016

MundoSk support it:

[on] armor stand (interact|manipulate)

player #The player who touched the armor stand
event-entity #The armor stand
player's tool #The item being put on
event-item #The item being take off
event-slot #The slot who is touched (helmet, chestplate, leggings, boots)

[on] armor stand place

event-entity #The armor stand

@bensku
Copy link
Member

bensku commented Aug 9, 2016

Fixed the bug with mob spawners. I was unable to reproduce the one with villagers, though.

Test script (no pseudocode) would help for that.

bensku added a commit that referenced this issue Aug 9, 2016
@netherstar
Copy link
Author

@bensku
bug with spawner still NOT fixed!
i use:

  • dev19 version
  • paperspigot 1.9.2
    with this skript, player still can change spawner with spawner egg, just press F to change hand.
#4 Anti Spawner Change via Egg
on rightclick on a monster spawner:
    player's tool is a spawn egg
    cancel event

@bensku
Copy link
Member

bensku commented Aug 28, 2016

Umm... Do you know what that script is actually doing? You are checking if main hand tool of player is spawn egg! Not surprising that it doesn't work if the egg is in off hand.

You should be checking for event-item.

@TheBentoBox
Copy link
Member

Long resolved and no response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

4 participants