Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache max in ConvertToRgba #982

Merged
merged 2 commits into from
Aug 15, 2019
Merged

cache max in ConvertToRgba #982

merged 2 commits into from
Aug 15, 2019

Conversation

SimonCropp
Copy link
Contributor

not sure if this is a fast path?

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #982 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage    89.7%   89.59%   -0.12%     
==========================================
  Files        1097     1097              
  Lines       48556    48544      -12     
  Branches     3422     3422              
==========================================
- Hits        43558    43492      -66     
- Misses       4295     4300       +5     
- Partials      703      752      +49
Impacted Files Coverage Δ
...der/ColorConverters/JpegColorConverter.FromCmyk.cs 100% <100%> (ø) ⬆️
...oder/ColorConverters/JpegColorConverter.FromRgb.cs 100% <100%> (ø) ⬆️
...olorConverters/JpegColorConverter.FromGrayScale.cs 100% <100%> (ø) ⬆️
...der/ColorConverters/JpegColorConverter.FromYccK.cs 100% <100%> (ø) ⬆️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.9% <0%> (-10.1%) ⬇️
...olorSpaces/Conversion/ColorSpaceConverter.Adapt.cs 60% <0%> (-8.58%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 87.64% <0%> (-6.75%) ⬇️
src/ImageSharp/Primitives/ValueSize.cs 78.94% <0%> (-5.27%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
....Tests/TestUtilities/Tests/TestEnvironmentTests.cs 63.63% <0%> (-4.55%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5643486...8fc01b3. Read the comment docs.

@antonfirsov antonfirsov merged commit f909517 into SixLabors:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants