Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis builds #891

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Fix travis builds #891

merged 2 commits into from
Apr 22, 2019

Conversation

antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Minimalistic subset of #872 to unblock our work.

@antonfirsov
Copy link
Member Author

@iamcarbon in #872, everything else seems C# 8 related to me. Am I missing something?

@antonfirsov antonfirsov mentioned this pull request Apr 22, 2019
4 tasks
@JimBobSquarePants
Copy link
Member

Very odd. I thought #872 updated appveyor.yml to ensure the builds happen in VS2019.

I'm not sure how it builds now while targeting C#8.

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #891 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   88.97%   88.98%   +0.01%     
==========================================
  Files        1018     1018              
  Lines       44579    44537      -42     
  Branches     3234     3220      -14     
==========================================
- Hits        39663    39632      -31     
+ Misses       4195     4194       -1     
+ Partials      721      711      -10
Impacted Files Coverage Δ
...ssing/Processors/Transforms/AutoOrientProcessor.cs 80.64% <0%> (-0.61%) ⬇️
...CC/DataReader/IccDataReader.MultiProcessElement.cs 90% <0%> (-0.48%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 93.25% <0%> (-0.36%) ⬇️
...ta/Profiles/ICC/DataReader/IccDataReader.Curves.cs 86.07% <0%> (-0.35%) ⬇️
src/ImageSharp/Formats/Bmp/BmpInfoHeader.cs 70.92% <0%> (-0.21%) ⬇️
...on/Implementation/Converters/HsvAndRgbConverter.cs 89.65% <0%> (-0.18%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 87.01% <0%> (-0.17%) ⬇️
src/ImageSharp/Processing/DetectEdgesExtensions.cs 96.42% <0%> (-0.13%) ⬇️
...iles/ICC/DataReader/IccDataReader.NonPrimitives.cs 93.65% <0%> (-0.1%) ⬇️
...files/ICC/DataReader/IccDataReader.TagDataEntry.cs 85.87% <0%> (-0.05%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a85ea7...e306994. Read the comment docs.

@antonfirsov antonfirsov merged commit bcd5f02 into master Apr 22, 2019
@JimBobSquarePants JimBobSquarePants deleted the af/fix-travis branch April 22, 2019 14:34
@iamcarbon
Copy link
Contributor

@JimBobSquarePants We only needed an SDK updated target C# 8.0 on AppVeyor. They updated the SDK in their standard image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants