-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised & extended test coverage for Resize #782
Conversation
allow consuming one-dimensional input in ImageDataAttribute.
This reverts commit e9dddc5.
more strict tolerance for the rest
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=========================================
Coverage ? 88.68%
=========================================
Files ? 1012
Lines ? 43306
Branches ? 3185
=========================================
Hits ? 38404
Misses ? 4197
Partials ? 705
Continue to review full report at Codecov.
|
// NeirestNeighbourResampler is producing slightly different results With classic .NET framework on 32bit | ||
// most likely because of differences in numeric behavior. | ||
// The difference is well visible when comparing output for | ||
// Resize_WorksWithAllResamplers_TestPattern301x1180_NearestNeighbor-300x480.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is worth to check (and cry).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not worth us trying to fix it. NN is low quality anyway and 32bit NET Framework would be increasingly rare. I’d put a note and skip test on those platforms.
Prerequisites
Issues addressed:
Resize_WorksWithAllResamplers
was not covering all resamplersAll new test cases were by changing/extending the input for
Resize_WorksWithAllResamplers
. We need these tests to implement #642 in a safe way.Unrelated changes:
TolerantMath.Default
is a readonly field now