-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Fix Porter-Duff Compositors #493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 86.86% 86.89% +0.03%
==========================================
Files 852 853 +1
Lines 36071 36095 +24
Branches 2654 2654
==========================================
+ Hits 31332 31364 +32
+ Misses 3978 3972 -6
+ Partials 761 759 -2
Continue to review full report at Codecov.
|
@JimBobSquarePants Can we merge in the grammatical errors? To make sure this doesn't get to big? Maybe a new PR and rebase this one? |
Perhaps, I could be wrong though and the fix could be super simple. |
@JimBobSquarePants great analysis of the problem! To summarize things further: This is how our output looks like with following the original order in the article: The list of the failing Blenders:
|
Go team! 🥇 |
WIP - Fix Porter-Duff Compositors
Prerequisites
Description
By my understanding our Porter-Duff equations are based upon the work here.
http://ssp.impulsetrain.com/porterduff.html
I've opened this PR to get work started on a fix.
Subtract
This is what we are looking for. Only a few of our output types are correct which leads me to think we've altered something fundamental when translating the formula. I think the input table values are correct.
I'm gonna need help on this as I can't make head-nor-tail of our interpretation of the formula. I'm a little concerned we'll need to create normalized vector methods for our
IPixel
implementations for it to work also.