Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling upload errors in logging #120

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Handling upload errors in logging #120

wants to merge 19 commits into from

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Dec 20, 2024

WiP, handling errors a bit better in the console logging.

This gets a better error handling in the SIP.upload function, and does some error display in Logging.fromAudit. Thus, if an upload error is encountered, instead of silently discarding it (just having an err return value to the upload), we show it in the logging part. This should ease error detection and recovery for the SIP.upload().then(Logging#print) flows that acts blindly. The errors are only printed at the warn level because it might be a normal flow, e.g. when running locally with missing credentials, …

@Jym77 Jym77 self-assigned this Dec 20, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 5790f5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@siteimprove/alfa-test-utils Minor
@siteimprove/alfa-angular Minor
@siteimprove/alfa-assert Minor
@siteimprove/alfa-chai Minor
@siteimprove/alfa-cheerio Minor
@siteimprove/alfa-cli Minor
@siteimprove/alfa-command Minor
@siteimprove/alfa-crawler Minor
@siteimprove/alfa-cypress Minor
@siteimprove/alfa-enzyme Minor
@siteimprove/alfa-formatter-earl Minor
@siteimprove/alfa-formatter-json Minor
@siteimprove/alfa-formatter-sarif Minor
@siteimprove/alfa-formatter Minor
@siteimprove/alfa-frontier Minor
@siteimprove/alfa-interviewer Minor
@siteimprove/alfa-jasmine Minor
@siteimprove/alfa-jest Minor
@siteimprove/alfa-jquery Minor
@siteimprove/alfa-playwright Minor
@siteimprove/alfa-puppeteer Minor
@siteimprove/alfa-react Minor
@siteimprove/alfa-scraper Minor
@siteimprove/alfa-selenium Minor
@siteimprove/alfa-unexpected Minor
@siteimprove/alfa-vue Minor
@siteimprove/alfa-webdriver Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Dec 20, 2024
@Jym77 Jym77 marked this pull request as ready for review January 20, 2025 13:14
@Jym77 Jym77 requested a review from a team as a code owner January 20, 2025 13:14
@Jym77 Jym77 marked this pull request as draft January 20, 2025 13:44
@Jym77 Jym77 marked this pull request as ready for review January 20, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Backwards-compatible change that touches public API
Projects
Status: 🧑‍💻 Doing
Development

Successfully merging this pull request may close these issues.

1 participant