fix: check if whitelisted lib is actually exists in the additional deps

[ArslanSaleem]

Important

Fix _check_imports in code_cleaning.py to ensure libraries are whitelisted before adding to _additional_dependencies, and update test to verify this.

• Behavior:
  • In code_cleaning.py, _check_imports now checks if a library is in WHITELISTED_LIBRARIES or custom_whitelisted_dependencies before adding to _additional_dependencies.
• Tests:
  • In test_code_cleaning.py, test_custom_whitelisted_dependencies now verifies that my_custom_library is added to _additional_dependencies when whitelisted.

^{This description was created by for 7fe07fa. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7fe07fa in 43 seconds

More details

• Looked at 58 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. tests/unit_tests/pipelines/smart_datalake/test_code_cleaning.py:309

• Draft comment:
  Consider adding a test to verify that non-whitelisted libraries are not added to _additional_dependencies. This ensures that the security measure is functioning correctly.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR modifies the _check_imports method to ensure that only whitelisted libraries are added to _additional_dependencies. The test test_custom_whitelisted_dependencies checks this behavior by asserting that a custom whitelisted library is added to _additional_dependencies. However, the test does not verify that non-whitelisted libraries are not added, which is crucial for security.

2. pandasai/pipelines/chat/code_cleaning.py:632

• Draft comment:
  The error message can be improved for clarity and conciseness.

                f"Library '{library}' is not whitelisted. "

• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_4WXEpaoHtpmCvqAY

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (daf5696) to head (7fe07fa).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   78.57%   78.56%   -0.01%     
==========================================
  Files         158      158              
  Lines        6323     6322       -1     
==========================================
- Hits         4968     4967       -1     
  Misses       1355     1355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.