Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Why "node-loader" is not in dev-dependancies #351

Closed
popod opened this issue Aug 9, 2017 · 3 comments
Closed

Why "node-loader" is not in dev-dependancies #351

popod opened this issue Aug 9, 2017 · 3 comments

Comments

@popod
Copy link

popod commented Aug 9, 2017

Why "node-loader" is not in dev-dependancies ? In my project, when I run karma unit, I got this error:

ERROR in ./app/node_modules/keytar-prebuild/lib/keytar.js
Module not found: Error: Can't resolve 'node-loader' in '/rootPath'
 @ ./app/node_modules/keytar-prebuild/lib/keytar.js 1:13-52
 @ ./app/src/renderer/routes.js
 @ ./app/src/renderer ^\.\/(?!main(\.js)?$)
 @ ./test/unit/index.js

In fact, this was because node-loader was not installed... Why ? It seems that it is used by default by webpack..

@develar
Copy link
Contributor

develar commented Aug 9, 2017

Hmmm.... Indeed, strange. The same bug in the electron-webpack.

Fixed in electron-webpack 0.11.1 (if #310 then this issue will be fixed).

develar added a commit to electron-userland/electron-webpack that referenced this issue Aug 9, 2017
@SimulatedGREG
Copy link
Owner

@popod

I'm not entirely sure where this got lost. node-loader was once in this boilerplate, but seems to have been removed by mistake. Will re-add back in an upcoming update.

@SimulatedGREG SimulatedGREG added this to the Updates & Bug fixes milestone Aug 9, 2017
SimulatedGREG added a commit that referenced this issue Aug 9, 2017
@SimulatedGREG
Copy link
Owner

Fixed in 0ee26cb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants