Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SecretRule From Picking Invalid Presets (#27456) #1805

Merged
merged 10 commits into from
Feb 17, 2025

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Feb 16, 2025

trying to fix the prelobby heisentest

we use votes anyway! fuck it, we ball

* Prevent SecretRule from picking invalid presets

* remove lonely semicolon

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Feb 16, 2025
@SimpleStation14 SimpleStation14 changed the title Prevent SecretRule from picking invalid presets (#27456) Prevent SecretRule From Picking Invalid Presets (#27456) Feb 16, 2025
sleepyyapril and others added 3 commits February 16, 2025 13:58
* add meteors into missing game presets

* changes for real

* implement code

* this too
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Feb 16, 2025
@VMSolidus
Copy link
Member

Oh yea fuck the meteor rework. That's the update that was so comically overtuned that it prompted Wizden to make the infamous "Space is so harmless, you can survive it indefinitely by taking a nap in a bed" PR. I actively encourage you to skip over the meteor scheduler update, and probably just yeet the meteor scheduler complaints from the YML Linter.

@VMSolidus VMSolidus merged commit d5d071a into Simple-Station:master Feb 17, 2025
10 of 11 checks passed
@sleepyyapril sleepyyapril deleted the quick,-fix-the-silly branch February 17, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants