Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v245.0.0 (and Storage UI V2) #1799

Merged
merged 20 commits into from
Feb 15, 2025
Merged

v245.0.0 (and Storage UI V2) #1799

merged 20 commits into from
Feb 15, 2025

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Feb 15, 2025 •
edited
Loading

Contains:

  • Storage UI v2, required for removing DeferredClose.
  • Stock market refactor (mostly some basic changes to stock market, didn't want to make a whole other PR for it)
  • Make guidebook remember where you left off
  • Any other PRs are purely for fixing issues related to the above PRs or the engine update.

🆑

  • add: Ported Storage UI v2.
  • tweak: The guidebook will now remember where you left off.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Feb 15, 2025
@VMSolidus
Copy link
Member

Screenshot_20250215-100609_Chrome

Im shocked we didnt get more of error. It should be fixable by just finding what wizd3n replaced DeferredClose with

@github-actions github-actions bot added the Changes: C# Changes any cs files label Feb 15, 2025
DrSmugleaf and others added 4 commits February 15, 2025 11:13
@github-actions github-actions bot added the Changes: UI Changes any XAML files label Feb 15, 2025
@sleepyyapril sleepyyapril changed the title v245.0.0 v245.0.0 (and Storage UI v2) Feb 15, 2025
@SimpleStation14 SimpleStation14 changed the title v245.0.0 (and Storage UI v2) v245.0.0 (and Storage UI V2) Feb 15, 2025
@sleepyyapril sleepyyapril changed the title v245.0.0 (and Storage UI V2) v242.0.0 (and Storage UI V2) Feb 15, 2025
sleepyyapril and others added 7 commits February 15, 2025 11:53
@sleepyyapril
243.0.1
b6f82d1
@sleepyyapril
v242.0.1
255e924
@sleepyyapril
okay v242.0.0 is safe
080d9eb
@deltanedas @sleepyyapril
stock market refactor (#2141)
07aa6ff 
* stock market refactor

* PlayEntity

* make client use int

* refactor and fix cartridge system

* fix

* deny sound if it fails

* reviews

* thank you ss14

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
@12rabbits @PJB3005 @sleepyyapril
Make guidebook remember where you left off (#31375)
06579f2 
* Guidebook tracks last read entry

* Persistent guidebook fixes

* Persistent guidebook requested changes

* Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
@deltanedas @gluesniffler @sleepyyapril
surgery cleanup stuff (Simple-Station#1634)
2e752d1 
* remove String uses

* remove AlwaysPushInheritance for strings

* move medbiofab to shitmed

* remove always push on body part

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: gluesniffler <159397573+gluesniffler@users.noreply.github.com>
@sleepyyapril
v245.0.0
99c4b6e
@sleepyyapril sleepyyapril changed the title v242.0.0 (and Storage UI V2) v245.0.0 (and Storage UI V2) Feb 15, 2025
sleepyyapril and others added 4 commits February 15, 2025 13:04
@sleepyyapril
fix imports
47dc56c
@AJCM-git @sleepyyapril
Fixed the guidebook listing every single rule (#28680)
a35f629 
* Well i tried this way

* New approach (start)

* Did it

* makes spacelaw available, put it under sec
@sleepyyapril
Remove unused
dbc61c4
@sleepyyapril
dependencyy
ff094ac
VMSolidus
VMSolidus approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't slept in 33 hours. Whatever happens after this is now "Well Rested Solidus's Problem"

@VMSolidus VMSolidus merged commit 3c37ff1 into Simple-Station:master Feb 15, 2025
11 of 12 checks passed
SimpleStation14 added a commit that referenced this pull request Feb 15, 2025
@SimpleStation14
Automatic Changelog Update (#1799)
8c65f88
@sleepyyapril sleepyyapril deleted the attempt-engine-update branch February 15, 2025 22:24
Bruno469 pushed a commit to Bruno469/Einstein-Engines that referenced this pull request Feb 20, 2025
@LaryNevesPR
Revert "Automatic Changelog Update (Simple-Station#1799)"
daacc9b 
This reverts commit 8c65f88.
Bruno469 pushed a commit to Bruno469/Einstein-Engines that referenced this pull request Feb 20, 2025
@LaryNevesPR
Revert "v245.0.0 (and Storage UI V2) (Simple-Station#1799)"
81ef40d 
This reverts commit 3c37ff1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@Remuchi Remuchi Awaiting requested review from Remuchi Remuchi is a code owner

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT DEATHB4DEFEAT is a code owner

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sleepyyapril @VMSolidus @ElectroJr @DrSmugleaf @metalgearsloth @deltanedas @12rabbits @AJCM-git