Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: deno has deprecated their bundler 🤷 We're currently pinning an old version which still has the bundler, but this will obviously lead to problems in the future.
First test looked like a simple switch and replace, but then i noticed that esbuild doesn't seem to support something like:
import * as Pako from "https://cdn.esm.sh/v66/pako@2.0.4/es2021/pako.js";
in the source files, which deno downloaded and inlined into the bundle, which seems like the ideal behavior from my perspective.We can either:
needs_bundling
, since right now we can only check if the main js file has changed on disc. Disadvantage : quite a bit of work to make it work reliably.