Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return parameters with lowest loss from LM optimizer #54

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Return parameters with lowest loss from LM optimizer #54

merged 1 commit into from
Nov 9, 2023
+15 −5

Conversation

SimonBoothroyd
Copy link
Owner

Description

This PR updates the LM optimiser to return the parameters with the lowest loss, rather than the parameters of the final step.

Status

  • Ready to go

@SimonBoothroyd SimonBoothroyd marked this pull request as ready for review November 8, 2023 23:38
@SimonBoothroyd SimonBoothroyd enabled auto-merge (squash) November 8, 2023 23:38
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Merging #54 (92ce224) into main (463b363) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 92ce224 differs from pull request most recent head 2b4f843. Consider uploading reports for the commit 2b4f843 to get more accurate results

@SimonBoothroyd SimonBoothroyd merged commit 092e2fe into main Nov 9, 2023
@SimonBoothroyd SimonBoothroyd deleted the lm-best-parameters branch November 9, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SimonBoothroyd