fix: 🐛 Enable seek gesture in paused mode #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Mar 14, 2024
hemantbeast
added a commit
to hemantbeast/audio_waveforms
that referenced
this pull request
May 28, 2024
ujas-m-simformsolutions
requested changes
Oct 14, 2024
cc18dea to
827191f
Compare
ujas-m-simformsolutions
requested changes
Oct 15, 2024
lib/src/audio_file_waveforms.dart
Outdated
| @@ -62,6 +62,9 @@ class AudioFileWaveforms extends StatefulWidget { | |||
| /// Allow seeking with gestures when turned on. | |||
| final bool enableSeekGesture; | |||
|
|
|||
| /// Allow seeking with gestures on pause mode. | |||
| final bool enableSeekGestureOnPauseMode; | |||
There was a problem hiding this comment.
we do not need this variable
There was a problem hiding this comment.
so it means we didn't provide access to enable and disable this functionality? @ujas-m-simformsolutions
Comment on lines
267
to
270
| if (progress < 0 || | ||
| _playerState.isStopped || | ||
| ((_playerState.isPaused || _playerState.isInitialised) && | ||
| !enableSeekGestureOnPauseMode)) return; |
There was a problem hiding this comment.
This can be simplified as suggested before.
cf7c0c0 to
fab7640
Compare
fab7640 to
65b5674
Compare
ujas-m-simformsolutions
approved these changes
Oct 15, 2024
hemantbeast
pushed a commit
to hemantbeast/audio_waveforms
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix 200.