Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugFix - Android recording doesn't work the first time after granting… #265

Merged
merged 2 commits into from
Mar 1, 2024
Merged

bugFix - Android recording doesn't work the first time after granting… #265

merged 2 commits into from
Mar 1, 2024

Conversation

himanshuGandhiSimform
Copy link
Collaborator

fix - Android recording doesn't work the first time after granting permissions

ujas-m-simformsolutions
ujas-m-simformsolutions reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention the issue this PR is solving so that after merging this PR, the issue can be automatically closed.

android/src/main/kotlin/com/simform/audio_waveforms/AudioRecorder.kt Show resolved Hide resolved
android/src/main/kotlin/com/simform/audio_waveforms/AudioRecorder.kt Show resolved Hide resolved
@himanshuGandhiSimform himanshuGandhiSimform linked an issue Feb 16, 2024 that may be closed by this pull request
Android recording doesn't work the first time after granting permissions #252
Closed
ujas-m-simformsolutions
ujas-m-simformsolutions requested changes Feb 20, 2024
View reviewed changes
android/src/main/kotlin/com/simform/audio_waveforms/AudioRecorder.kt Outdated
@@ -205,4 +208,8 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
else -> return MediaRecorder.OutputFormat.MPEG_4
}
}

fun interface RequestPermissionsSuccessCallback {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in a utils file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @ujas-m-simformsolutions

ujas-m-simformsolutions
ujas-m-simformsolutions approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himanshuGandhiSimform himanshuGandhiSimform merged commit d91c33e into main Mar 1, 2024
@himanshuGandhiSimform himanshuGandhiSimform deleted the fix/252_android_first_time_recording_not_working_when_permission_grant branch March 1, 2024 04:03
@himanshuGandhiSimform himanshuGandhiSimform mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujas-m-simformsolutions ujas-m-simformsolutions ujas-m-simformsolutions approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android recording doesn't work the first time after granting permissions
2 participants
@himanshuGandhiSimform @ujas-m-simformsolutions