Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed last wave flickering and minor docs update #197

Merged
merged 1 commit into from
Sep 29, 2023
Merged

🐛 Fixed last wave flickering and minor docs update #197

merged 1 commit into from
Sep 29, 2023

Conversation

ujas-m-simformsolutions
Copy link
Collaborator

@ujas-m-simformsolutions ujas-m-simformsolutions commented Mar 16, 2023 •
edited
Loading

Fixes #44

@PassantAbdelatif
Copy link

Any update about this bug that the last wave flickering

@ujas-m-simformsolutions
Copy link
Collaborator Author

@PassantAbdelatif This PR still need to be tested for AudioFileWaveforms. That's why it hasn't been merged. We will merge this as soon as possible. Thank you for your patience.

@ujas-m-simformsolutions ujas-m-simformsolutions marked this pull request as draft April 14, 2023 08:04
@ujas-m-simformsolutions ujas-m-simformsolutions force-pushed the bugFix/fix_last_wave_flickering branch from 2cba067 to d2e1c37 Compare April 14, 2023 08:15
@ujas-m-simformsolutions ujas-m-simformsolutions marked this pull request as ready for review April 14, 2023 08:16
@ujas-m-simformsolutions ujas-m-simformsolutions force-pushed the bugFix/fix_last_wave_flickering branch from d2e1c37 to d1f8972 Compare August 16, 2023 13:15
@guplem
Copy link

guplem commented Sep 28, 2023 •
edited
Loading

@ujas-m-simformsolutions @dhvanit-v-simformsolutions @vatsaltanna-simformsolutions when will this be merged?
I have been using the latest commit on this pull request as my version for the package for a while now.

In case anyone is interested, this is how I do it:

  audio_waveforms: #WAITING FOR UPDATE https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/197
    git:
      url: https://github.com/SimformSolutionsPvtLtd/audio_waveforms.git
      ref: 053c3c26407b5b50e060007f891690b379ca5bb2

@Ujas-Majithiya
🐛 Fixed last wave flickering and minor docs update
053c3c2 
Signed-off-by: Ujas-Majithiya <ujasthakkar54@gmail.com>
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions deleted the bugFix/fix_last_wave_flickering branch September 29, 2023 05:54
@guplem
Copy link

guplem commented Sep 29, 2023

@vatsaltanna-simformsolutions Thank you very much for the merge!
Are you planning on creating a new release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhvanit-v-simformsolutions dhvanit-v-simformsolutions dhvanit-v-simformsolutions left review comments

@aditya-css aditya-css aditya-css approved these changes

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions vatsaltanna-simformsolutions approved these changes

@PassantAbdelatif PassantAbdelatif PassantAbdelatif approved these changes

@guplem guplem guplem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The last wave form is always flickering when recording
7 participants
@ujas-m-simformsolutions @PassantAbdelatif @guplem @vatsaltanna-simformsolutions @aditya-css @dhvanit-v-simformsolutions @Ujas-Majithiya