📝 Updated example app 🔨 Fixed tap gesture not working and fixed platform stream being initialised multiple times #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Prepare player with extracting waveform if index is even. | ||
| controller.preparePlayer( | ||
| path: widget.path ?? file!.path, | ||
| shouldExtractWaveform: widget.index?.isEven ?? true, |
There was a problem hiding this comment.
null check for file!.path
example/lib/chat_bubble.dart
Outdated
| void dispose() { | ||
| super.dispose(); | ||
| playerStateSubscription.cancel(); | ||
| if (widget.isLast) { |
There was a problem hiding this comment.
I guess isLastIndex can be more appropriate
| mainAxisSize: MainAxisSize.min, | ||
| children: [ | ||
| if (controller.playerState != PlayerState.stopped) | ||
| IconButton( |
There was a problem hiding this comment.
If these states come from our plugin than please make extensions for same like isStopped
| ); | ||
| isPlaying = | ||
| controller.playerState == PlayerState.playing; | ||
| }, |
dhvanit-v-simformsolutions
suggested changes
Dec 20, 2022
0c94610 to
2c9082d
Compare
…orm stream being initialised multiple times
2c9082d to
dd8667a
Compare
dhvanit-v-simformsolutions
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.