Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command pallete fix #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Command pallete fix #19

wants to merge 2 commits into from

Conversation

suhailmalik07
Copy link

Fixes issue #18

@suhailmalik07
Copy link
Author

suhailmalik07 commented Jul 12, 2024 •
edited
Loading

Hey, Please let me know what else needed to be done here.

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jul 12, 2024

PR Summary

  • Added Editor Text Focus Condition to Keybindings
    The keybindings in both package.json and built-in.ts files have been updated to include conditions related to editorTextFocus. This ensures that these keybindings only function when the text editor is in focus.

  • Added Dance Mode Condition to Keybindings
    The keybindings in the built-in.ts file have been updated to include dance.mode in their conditions. This improvement will help ensure that these keybindings only operate when the Dance Mode is active.

  • Changed Unused Conditions in Keybindings
    The unused $exclude conditions in the built-in.ts file have been replaced with $exclude: [] for several keybindings. This simplifies the overall programming logic by ensuring no unintentional conditions are applied.

  • Updated Several Functions in qwerty.md
    Several functions, such as selections.copy.above, selections.faceForward, selections.hideIndices, selections.orderAscending, selections.orderDescending, etc., have been updated in src/commands/layouts/qwerty.md. This helps to document how these functions work and can improve developer understanding.

  • Updated splitLines Function in selections.ts
    The splitLines function on line 429 of src/commands/selections.ts file has been updated. This edit can affect how this function performs its job, possibly making it more efficient or suited to new requirements.

suhailmalik07
suhailmalik07 commented Jul 12, 2024
View reviewed changes
src/commands/layouts/qwerty.md
<tr><td><a href="../selections.ts#L808"><code>selections.copy.above</code></a></td><td>Copy selections above</td><td><code>Shift+Alt+C</code> (<code>editorTextFocus && dance.mode == 'normal'</code>)<code>Shift+Alt+C</code> (<code>editorTextFocus && dance.mode == 'visual'</code>)</td></tr>
<tr><td><a href="../selections.ts#L660"><code>selections.faceBackward</code></a></td><td>Backward selections</td><td></td></tr>
<tr><td><a href="../selections.ts#L659"><code>selections.faceForward</code></a></td><td>Forward selections</td><td><code>Shift+Alt+;</code> (<code>editorTextFocus && dance.mode == 'normal'</code>)</td></tr>
<tr><td><a href="../selections.ts#L807"><code>selections.copy.above</code></a></td><td>Copy selections above</td><td><code>Shift+Alt+C</code> (<code>editorTextFocus && dance.mode == 'normal'</code>)<code>Shift+Alt+C</code> (<code>editorTextFocus && dance.mode == 'visual'</code>)</td></tr>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are supposed to be correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suhailmalik07