-
Notifications
You must be signed in to change notification settings - Fork 45.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Benchmarks write cassettes without using them #4664
Make Benchmarks write cassettes without using them #4664
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
6dbdced
to
da3ff8f
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4664 +/- ##
==========================================
+ Coverage 70.43% 70.64% +0.20%
==========================================
Files 70 70
Lines 3437 3437
Branches 547 547
==========================================
+ Hits 2421 2428 +7
+ Misses 848 837 -11
- Partials 168 172 +4 ☔ View full report in Codecov by Sentry. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
da3ff8f
to
7214b2e
Compare
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay run more tests from scratch. use cassettes less. get more data
Background
Benchmarks retry tests once if they fail. If they use cassettes, the second test is doomed to fail as well.
Changes
Documentation
Test Plan
PR Quality Checklist