Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra spaces in summarization prompt #4660

Merged

Conversation

kinance
Copy link
Contributor

@kinance kinance commented Jun 11, 2023

Background

Left some extra spaces in the summarization prompt when making the batch summarization change #4652

Changes

Removed the extra spaces

Test Plan

Reran the tests and succeeded

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2023 0:08am

@netlify
Copy link

netlify bot commented Jun 11, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 04f7ab2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/648661ec7a21fe0008770252

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (62dd167) 70.01% compared to head (04f7ab2) 70.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4660      +/-   ##
==========================================
+ Coverage   70.01%   70.06%   +0.05%     
==========================================
  Files          72       72              
  Lines        3598     3598              
  Branches      572      572              
==========================================
+ Hits         2519     2521       +2     
+ Misses        895      894       -1     
+ Partials      184      183       -1     
Impacted Files Coverage Δ
autogpt/memory/message_history.py 85.41% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview June 11, 2023 23:26 Inactive
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Pwuts Pwuts self-assigned this Jun 11, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@Pwuts Pwuts merged commit ff46c16 into Significant-Gravitas:master Jun 12, 2023
@kinance kinance deleted the fix-touch-up-summarization-prompt branch June 12, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants