Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

start fixtures, types, challenge creation, mock run (stable #37

Merged
merged 10 commits into from
Jun 21, 2023

Conversation

SilenNaihin
Copy link
Contributor

@SilenNaihin SilenNaihin commented Jun 21, 2023

Creating all of the starter code other than the server boilerplate.

  • in agbenchmark/define_task_types.py define challenge creation schema
  • view it in action in agbenchmark/challenges/retrieval/r1_test.py
  • follow the chain of inheritance to the challenge specific class at agbenchmark/retrieval/Retrieval.py
  • all the way down to the base challenge class agbenchmark/Challenge.py which all challenges inherit
  • agbenchmark/start_benchmark for click
  • agbenchmark/conftest for fixtures (including getting the config file, getting workspace path and cleaning workspace after test, and mock test/server call)

@ScarletPan
Copy link
Contributor

ScarletPan commented Jun 21, 2023

Hi @SilenNaihin , it's not recommended to include challenge data within the Python file, as this can make it difficult to scale the benchmark and allow others to contribute challenges using a simple JSON format. The data folder, samples for each challenges and README.md should be kept, as they provide guidance for each type of challenge.

@ScarletPan
Copy link
Contributor

ScarletPan commented Jun 21, 2023

The config.json file and mocks folder should also be excluded from the agbenchmark folder, as it will be modified every time you run the program.

Error message shows up [Error 2] No such file or directory: /xxx/agbenchmark/mocks/workspace/file_to_check.txt

@AbTrax
Copy link

AbTrax commented Jun 21, 2023

Other than what pan said, I can't see anything else.

@SilenNaihin
Copy link
Contributor Author

SilenNaihin commented Jun 21, 2023

Thank for the comments @ScarletPan @AbTrax, writing out for reference

not recommended to include challenge data within the Python file

good point, I moved it to a r1_data.json file that lives within a directory for that specific challenge (ease of access per challenge)

data folder, samples for each challenges and readme should be kept

this has become the mocks folder now. added back the read me to the challenges folder, good point there

config.json file and mocks should also be excluded from the agbenchmark folder

typically yes, but since this is a pip installable package in order to interact with it through poetry these must be in the agbenchmark folder - that is functionally the root of the project

error

did you follow the instructions outlined in readme to run it?

  1. clone the repo auto-gpt-benchmarks
  2. pip install poetry
  3. poetry shell
  4. poetry install
  5. agbenchmark start

@SilenNaihin SilenNaihin merged commit b7deb98 into master Jun 21, 2023
@SilenNaihin SilenNaihin deleted the start-benchmark branch June 21, 2023 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants