Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

Sync skill tree to a versioned website #289

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Aug 12, 2023

Background

Changes

  • github.io is pretty useful to have versioned websites linked to each release => quick prototype.
  • I need the next release of agbenchmark to release the skill tree, so we can get feedback from users.

PR Quality Checklist

  • I have run the following commands against my code to ensure it passes our linters:
    black . --exclude test.py
    isort .
    mypy .
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring --in-place agbenchmark

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
@waynehamadi waynehamadi temporarily deployed to testing August 12, 2023 00:24 — with GitHub Actions Inactive
@github-actions
Copy link

PR Analysis

  • 🎯 Main theme: Syncing the skill tree to the versioned website
  • 📌 Type of PR: Enhancement
  • Focused PR: True
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • General suggestions: The PR seems to be well-structured and focused on syncing the skill tree to the versioned website. However, it would be beneficial to add tests to ensure the functionality works as expected.

  • 🤖 Code feedback:

    • relevant file: agbenchmark/utils/dependencies/main.py
      suggestion: It's a good practice to avoid using environment variables directly in the code. Instead, consider using a configuration file or command line arguments to pass these values. This would make the code more maintainable and less prone to errors due to environment variables not being set correctly. [important]
      relevant line: build_skill_tree = os.getenv("BUILD_SKILL_TREE")

    • relevant file: .github/workflows/ci.yml
      suggestion: It's recommended to avoid hardcoding credentials or tokens directly in the code. Instead, consider using GitHub secrets or other secure ways to handle sensitive information. [important]
      relevant line: git remote set-url origin https://x-access-token:${{ env.GH_TOKEN }}@github.com/agbenchmark/skill-tree.github.io.git

    • relevant file: agbenchmark/utils/dependencies/graphs.py
      suggestion: It's a good practice to avoid hardcoding file paths in the code. Instead, consider using a configuration file or command line arguments to pass these values. This would make the code more maintainable and adaptable to different environments. [medium]
      relevant line: relative_path = "agbenchmark/challenges/skill_tree/dependencies.html"

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@waynehamadi waynehamadi changed the title Sync skill tree to versioned website Sync skill tree to a versioned website Aug 12, 2023
@waynehamadi waynehamadi merged commit 1560892 into master Aug 12, 2023
@waynehamadi waynehamadi deleted the sync-skill-tree-to-versioned-website branch August 12, 2023 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant