Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

Clean up workspace between each test #109

Merged

Conversation

erik-megarad
Copy link
Contributor

Background

Files in the workspace were being retained between test runs of the same module.

Changes

Change the workspace setup to run before each test

PR Quality Checklist

  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy .
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring --in-place agbenchmark

Copy link

@ai-maintainer ai-maintainer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-Maintainer Review for PR - Clean up workspace between each test

Title and Description 👍

The Title and Description are clear and concise

The title and description of the pull request are clear and concise. They effectively communicate the purpose of the changes, which is to clean up the workspace between each test to prevent files from being retained between test runs.

Scope of Changes 👍

The changes are narrowly focused

The changes in this pull request are narrowly focused on resolving a specific issue related to the workspace setup. The author is not trying to resolve multiple issues simultaneously, which is a good practice as it makes the changes easier to review and understand.

Testing ⚠️

Testing details are not provided

The description does not provide explicit details on how the changes were tested. While the PR Quality Checklist suggests that the author has taken steps to ensure code quality, it would be beneficial to provide more information about the testing approach followed. This would help reviewers understand how the changes were validated.

Code Documentation 👍

No new functions, classes, or methods added

In the provided diff, there is no newly added function, class, or method. Therefore, there are no functions, classes, or methods that need docstrings.

Suggested Changes

  • Please provide more information about how the changes were tested. This could include the specific tests that were run, any new tests that were added, or any manual testing that was performed.

  • While the current changes do not introduce any new functions, classes, or methods, it's always a good practice to ensure that all functions, classes, or methods are well-documented with docstrings. This will make the code easier to understand and maintain in the future.

Reviewed with AI Maintainer

@waynehamadi waynehamadi merged commit cbd2e49 into Significant-Gravitas:master Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants