SKPutRequest not updating values and untracked RequestId on Put #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairas
reviewed
Jul 16, 2022
src/sensesp/net/ws_client.cpp
Outdated
| @@ -274,7 +275,7 @@ void WSClient::process_received_updates() { | |||
| SKListener::take_semaphore(); | |||
|
|
|||
| const std::vector<SKListener*>& listeners = SKListener::get_listeners(); | |||
|
|
|||
| const std::vector<SKPutListener*>& Plisteners = SKPutListener::get_listeners(); | |||
There was a problem hiding this comment.
Nitpick: SensESP is following the Google C++ Style Guide and as such, member variables should have snake_case. So, I'd rename Plisteners to put_listeners.
There was a problem hiding this comment.
Nice to have holiday sail !! of course, ok for the variable name, I am not a professional programmer, just a retired biomedical engineer. I will try to read the Google C++ Style Guide.
Not sure that it's possible to optimize the code by using one vector and one loop (less program memory), I found it more readable like that.
|
Looks great now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!!
my first PR on Github...
When a PutRequest is received by SensESP , a debuglog message " Untracked RequestID" and the value changed is not updated.
The code presented in PR is working fine for my application based on SmartSwitchcontroller.