wallet: fix wallet Redistribute when outputs is larger than batchsize #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e99e9fa to
21a7181
Compare
peterjan
approved these changes
Feb 10, 2025
bb3e685 to
2574e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the tests we have to make sure we verify a redistribution of outputs that requires more than a single transaction.
Atm that doesn't work since multiple batches will reuse the same inputs, creating an invalid txn set in the process. Also signing a set that is the result of a v1 redistribution doesn't work because
SignTransactionwill add redundant signatures to txns.This PR fixes both of these issues.
Closes #169