Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked TM wrong. Fixed. Needs manual approval (spiral) #168

Merged
merged 6 commits into from
May 18, 2024

Conversation

silkBee
Copy link
Contributor

@silkBee silkBee commented May 18, 2024

Needs manual approval due to the spiral

Copy link

Thank you for uploading your design!

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit.

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

Thank you for uploading your design!

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit.

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

Thank you for uploading your design!

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit.

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

@silkBee
Copy link
Contributor Author

silkBee commented May 18, 2024

Could you please manually approve this? This is hopefully the last version of the spiral one.
This time I had to change TE mode to TM mode in the label for one MZI. Thanks!

Copy link

Thank you for uploading your design!

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit.

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

@silkBee
Copy link
Contributor Author

silkBee commented May 18, 2024

I made a change to the spiral one after pr/162. I realized one MZI was TM mode but the label said TE, and I fixed it and resubmitted pr 168

@lukasc-ubc
Copy link
Member

I don't see any spirals. just ring resonators. Is this correct?

image

@silkBee
Copy link
Contributor Author

silkBee commented May 18, 2024

I submitted PR168 EBeam_Lily_Yuan_A (spiral), then while waiting for manual approval, I also tried to submit EBeam_Lily_Yuan_B (resonators) but could not see the "create a new pull request" button. Shall I redo either one, or both?

@lukasc-ubc
Copy link
Member

It seems like only your A file is not there. I will merge this one. Please create a new PR for the spirals.

image

@lukasc-ubc lukasc-ubc merged commit 76671d4 into SiEPIC:main May 18, 2024
1 check passed
@silkBee
Copy link
Contributor Author

silkBee commented May 18, 2024

Looks like I should not have upload B while waiting for A.
I just submitted PR180 EBeam_Lily_Yuan_A (spiral). Please help manually approve and merge. Thanks Prof Lucas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants