-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked TM wrong. Fixed. Needs manual approval (spiral) #168
Conversation
Needs manual approval due to the spiral
Thank you for uploading your design! If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V). Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit. You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline. |
Thank you for uploading your design! If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V). Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit. You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline. |
Thank you for uploading your design! If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V). Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit. You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline. |
Could you please manually approve this? This is hopefully the last version of the spiral one. |
Thank you for uploading your design! If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V). Please note that we have added a new rule (on May 2, 2024) to SiEPIC-Tools and the EBeam PDK: The grating coupler spacing (pitch) must be at least 60.0 microns. This is to help avoid the probe station from accidentally aligning to an adjacent circuit. You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline. |
I made a change to the spiral one after pr/162. I realized one MZI was TM mode but the label said TE, and I fixed it and resubmitted pr 168 |
I submitted PR168 EBeam_Lily_Yuan_A (spiral), then while waiting for manual approval, I also tried to submit EBeam_Lily_Yuan_B (resonators) but could not see the "create a new pull request" button. Shall I redo either one, or both? |
Looks like I should not have upload B while waiting for A. |
Needs manual approval due to the spiral