Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README from Mat #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README from Mat #14

wants to merge 2 commits into from

Conversation

mvbeek
Copy link

@mvbeek mvbeek commented Jun 10, 2022

I have updated the README document as requested Shota, I added in a few new fields as well and corrected some spelling mistakes :)

I have updated the README document as requested Shota, I added in a few new fields as well :)
README.md Outdated
@@ -50,25 +50,73 @@ You should start 4 instances parallel.
Instance 1

```
First run
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvbeek in the code section, can you remove the explanation? please include the command.

@@ -50,25 +50,73 @@ You should start 4 instances parallel.
Instance 1

```
First run
brew install librdkafka

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also line brake is not necessary

README.md Outdated
brew services list

then run
git branch
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these git commands are not necessary.

README.md Outdated
mosquitto -c config/mosquitto.conf

and
brew services start mosquitto
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command is not necessary as mosquitto -c config/mosquitto.conf will take care of this.

```

Instance 2

```
cd ssa_iot

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please remove the line brake for consistency. Please apply to all the code section.

README.md Outdated
To monitor commands in MQTT use the below command in a new terminal

```
mosquitto_sub -t "#" -h localhost -v
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the security reasons, this has to be blocked by the access control (I have changed your config file (config/mosquitto.conf by changing allow_annonymous false to true to remove the access control). So we do not allow this for this assignment.

@ShotaKameyama
Copy link
Owner

@mvbeek I have checked your readme, I haven't commented to all the lines but please modify the following.

  • remove the line brakes, explanation in the code section
    • we only need commands
  • for mosquitto_sub -t "#", we will not show this by allow_anonymous false so we do not need this explanation.

@@ -16,7 +16,7 @@ The following should be installed already before setup.
## Install Necessary Source Code and Libraries

```
git clone https://github.com/ShotaKameyama/ssa_iot.git`
git clone https://github.com/ShotaKameyama/ssa_iot.git
Copy link
Author

@mvbeek mvbeek Jun 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra ` which when copied made the code not work when copied.

@@ -37,10 +37,10 @@ This shell script will take care of the following:
4. Add Environment Variables to `~/.bash_profile`


# Basic Inforamtion
# Basic Information
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling correction


This IoT system consists of 4 instances:
- MQTT braker
- MQTT broker
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling correction

Hi Shota,
I have made changes as requested.
Comment on lines +55 to +58

git log
git pull

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not necessary

mosquitto -c config/mosquitto.conf

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line is not necessary.

cd ssa_iot

source ~/.bash_profile

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line is not necessary.

```
cd ssa_iot

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line is not ncecessary

cd ssa_iot

source ~/.bash_profile

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line is not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants