-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflix project #1
base: review
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really great job! Let me know if y9ou have any questions
# production | ||
/build | ||
|
||
# misc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you use a .env
dont forget to add it here
} | ||
} | ||
|
||
rentMovie = (movieID, result) =>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you use somthing over and over, it would be best just to redefine it to make your code cleaner
const {users, currentUserID, catalog} = this.state
rentMovie = (id, result ) =>{ | ||
this.props.rentMovie(id, result) | ||
} | ||
handleSearch = (event) =>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can also write it like
handleSearch = ({target}) => this.setState({searchTerm: target.value})
|
||
|
||
ReactDOM.render( | ||
<React.StrictMode> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove React.StrictMode. I can keep reloading your app and causing your problems.
ReactDOM.render(
<App />,
document.getElementById('root')
);
No description provided.