V16.0.7-shopify-1 #139
Closed
V16.0.7-shopify-1 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Address internal review comments Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Fix apparent bug in KeyRangeContiguous when a or b are full-range Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Add test for bug in comparing "0003" vs "000300" Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com> Remove trailing zeroes in key.Normalize instead of adding padding Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Address review feedback; test formatting, comments, function naming Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Refactor tests for TestKeyRangesIntersect Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Rename KeyRangesIntersect to KeyRangeIntersect for consistency Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Remove unused KeyRangesOverlap function Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Rename KeyRangeIncludes to KeyRangeContainsKeyRange, clean up and add tests Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>
Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>
Signed-off-by: austenLacy <austenlacy@gmail.com>
Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
* purge old schema versions from memory in historian Signed-off-by: austenLacy <austenlacy@gmail.com> * fix vttablet arg e2e test Signed-off-by: Austen Lacy <austen.lacy@shopify.com> * only reassign historian schemas if necessary Signed-off-by: Austen Lacy <austen.lacy@shopify.com> * dont use from_unixtime in query because already in unix Signed-off-by: Austen Lacy <austen.lacy@shopify.com> --------- Signed-off-by: austenLacy <austenlacy@gmail.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
Generated via `make sizegen` Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
…sio#13065) (#107) Co-authored-by: Hormoz Kheradmand <hkdsun@users.noreply.github.com>
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <mattalord@gmail.com> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <austen.lacy@shopify.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
…ication status (vitessio#14436) (#128) Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
3592ac6 to
b8bb5c9
Compare
|
closing in favor of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.