WIP: Replace BaseInput
with BaseMetaInput
#2585
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Spawned from, https://github.com/Shopify/pos-next-react-native/pull/51443 which automatically prepends
BaseInput
data to every worker run call on POS.Goal here is so there is a clear separation for,
Coupling them makes it difficult to separate type concerns on POS.
Solution
BaseInput
properties toBaseMetaInput
.BaseInput
as placeholder for all event targets*Inputs
.BaseMetaInput
types are not needed as arguments forExtensionRunner.run()
, only forUnifiedExtensionWorker.run()
.ExtensionRunner.run()
referencing the correct*Inputs
type, and optionallyUnifiedExtensionWorker.run()
can reference the combined typings (currently typed asany
).🎩
./scripts/ui-extensions/yalc-local-extensions add
.Checklist