-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add billing address hook to customer accounts #2583
Conversation
a57d363
to
da6f4e1
Compare
We detected some changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to backfill existing stable versions?
Yes, we also have another api we want to backfill (SKU field) |
|
||
import {mount, createMockStatefulRemoteSubscribable} from './mount'; | ||
|
||
describe('useBillingAddress', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a test that tests the error case? 🙏
Like we did here:
Line 7 in e739ca6
it('raises an exception without approval scopes granted', () => { |
It's also odd that we have a shopping and a shipping address test where one tests the happy path and one tests the error case. Those should be in the same file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, cleaned it up
Background
Adds a missing helper react hook for billing address.
The data is already available in the API spec, this just adds a helper to access it.
Solution
N/A
🎩
Checklist