This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Partially fixing #863.
Problem
When Themekit is deploying on Shopify, it will show progress like this :
[environment]: 10 / 30 [=====================>--------------] 33 %
which works great when you are using the default
config.yml
files.Since we are using
.env
files, Themekit doesn't understand that there's multiple environment. So we always show[development]
even if we are using another environment.If we try to add the
--env
flag to our _generateConfigFlags(), Themekit will complain that there's no 'staging' environment, for example :staging does not exist in this environments list
.Solution
I suggest adding the environment in the
↑ Uploading to Shopify...
message above as a workaround.The developer will now see :
I don't think it's perfect, but it works for now.