This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Fix instance removal #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f82f6d to
f739bc6
Compare
t-kelly
approved these changes
Jan 30, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* update install guide to global * version shorthand to lowercase v * update contributing and global flag
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* update install guide to global * version shorthand to lowercase v * update contributing and global flag
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* update install guide to global * version shorthand to lowercase v * update contributing and global flag
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR wasn't quite right. When unloading a section we should fire the
onUnloadfunction of that instance if it exists and then remove it fromthis.instances.Before this PR, the
onUnloadfunction of every remaining section would fire instead of the only one we really want.