locale based pagination strings

[NathanPJF]

Replace hardcoded strings with pagination translations.

[NathanPJF]

hmmm... Cirlce CI says:

Unused keys:
        general.pagination.previous
       	general.pagination.next
     # ./spec/i18n_parity_spec.rb:28:in `block (2 levels) in <top (required)>'

I'm using them... but assigning them to variables first because I can't write:

{{ paginate | default_pagination: previous: 'general.pagination.previous' | t }}

[NathanPJF]

Ah, has to do with how the test define FILE_KEYS. The match_keys function is only counting uses of {{ * | t}} : https://github.com/Shopify/slate/blob/master/spec/helpers/i18n_helper.rb#L4

So I'm going to close this in favour of the other PR.

Feel it's not worth writing a test that looks for cases of assign var = <some translation> and then making sure that var is used.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.