Add test for 'webpack.commonExcludes' config

packages/slate-tools/tools/webpack/config/core.js

@@ -6,7 +6,7 @@ const CopyWebpackPlugin = require('copy-webpack-plugin');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
 const SlateConfig = require('@shopify/slate-config');
 
-const commonExcludes = require('../common-excludes');
+const commonExcludes = require('./utilities/common-excludes');
 const {entrypointFiles} = require('../entrypoints');
 const config = new SlateConfig(require('../../../slate-tools.schema'));
 

packages/slate-tools/tools/webpack/config/dev.js

@@ -7,7 +7,7 @@ const SlateConfig = require('@shopify/slate-config');
 
 const webpackCoreConfig = require('./core');
 const babel = require('./parts/babel');
-const commonExcludes = require('../common-excludes');
+const commonExcludes = require('./utilities/common-excludes');
 const {templateFiles, layoutFiles} = require('../entrypoints');
 const HtmlWebpackIncludeLiquidStylesPlugin = require('../html-webpack-include-chunks');
 const config = new SlateConfig(require('../../../slate-tools.schema'));

packages/slate-tools/tools/webpack/config/parts/babel.js

@@ -1,7 +1,7 @@
 const fs = require('fs');
 const SlateConfig = require('@shopify/slate-config');
 
-const commonExcludes = require('../../common-excludes');
+const commonExcludes = require('../utilities/common-excludes');
 const config = new SlateConfig(require('../../../../slate-tools.schema'));
 
 module.exports = () => {

packages/slate-tools/tools/webpack/config/parts/sass.prod.js

@@ -3,7 +3,7 @@ const autoprefixer = require('autoprefixer');
 const cssnano = require('cssnano');
 const SlateConfig = require('@shopify/slate-config');
 
-const commonExcludes = require('../../common-excludes');
+const commonExcludes = require('../utilities/common-excludes');
 const config = new SlateConfig(require('../../../../slate-tools.schema'));
 
 const extractStyles = new ExtractTextPlugin({

packages/slate-tools/tools/webpack/config/prod.js

@@ -11,7 +11,7 @@ const SlateTagPlugin = require('@shopify/slate-tag-webpack-plugin');
 
 const babel = require('./parts/babel');
 const sass = require('./parts/sass.prod');
-const commonExcludes = require('../common-excludes');
+const commonExcludes = require('./utilities/common-excludes');
 const webpackCoreConfig = require('./core');
 const packageJson = require('../../../package.json');
 const getChunkName = require('../get-chunk-name');

packages/slate-tools/tools/webpack/config/utilities/__tests__/common-excludes.test.js

@@ -0,0 +1,10 @@
+test(`includes the values specified in 'webpack.commonExcludes' config`, () => {
+  global.slateUserConfig = {
+    'webpack.commonExcludes': ['some', 'values'],
+  };
+  const commonExcludes = require('../common-excludes');
+
+  global.slateUserConfig['webpack.commonExcludes'].forEach((item) => {
+    expect(commonExcludes().toString()).toMatch(item);
+  });
+});

packages/slate-tools/tools/webpack/common-excludes.js → packages/slate-tools/tools/webpack/config/utilities/common-excludes.js

@@ -1,5 +1,5 @@
 const SlateConfig = require('@shopify/slate-config');
-const config = new SlateConfig(require('../../slate-tools.schema'));
+const config = new SlateConfig(require('../../../../slate-tools.schema'));
 
 module.exports = (...params) =>
   new RegExp([...config.get('webpack.commonExcludes'), ...params].join('|'));