Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Docs new getting started #205

Merged
merged 6 commits into from
Jul 19, 2017
Merged

Docs new getting started #205

merged 6 commits into from
Jul 19, 2017

Conversation

NathanPJF
Copy link
Contributor

@NathanPJF NathanPJF commented Jul 19, 2017

What are you trying to accomplish with this PR?

New documentation to reflect the changes coming from 0.11.0 #202

Additionally, I've changed the setup instructions to start a new project from a manual deploy. The existing steps were shorter, but it also assumed you had a theme in your store you'd want to overwrite (to get the theme ID). The problem with this is now your live theme may have folders not in your local project.

Checklist

For contributors:

For maintainers:

  • I have 🎩'd these changes.
  • I have bumped the package.json version in a separate PR, if applicable.

@NathanPJF NathanPJF requested a review from bertiful July 19, 2017 19:01
Copy link
Contributor

@bertiful bertiful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I really like the breakdown between creating a new project and connecting that project to your Shopify store.


Create `config.yml` in your root using [this sample file](https://github.com/Shopify/slate/blob/master/config-sample.yml), then use [theme commands](#theme-commands) to start developing.
A `config.yml` will also be created in your root directory which is required for [build commands](#build-commands) and [sync commands](#sync-commands).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

docs/index.md Outdated
@@ -47,8 +69,8 @@ The steps below walk through installing Slate globally and configuring your deve

> Learn more about [all commands and descriptions](/slate/commands/) or how to [deploy to multiple environments](/slate/commands/#sync-commands).

## Working with `git`
## Working with git repositories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize Git

docs/index.md Outdated

A new Slate project comes with a `.gitignore-sample` file. This file is meant to be a starting point for your own `.gitignore` file if you will be using `git` for version control. The sample files contains a list of files and folders to be ignored when committing to a git repository. Ignored files are both Slate project specific files as well as commonly ignored files on any project.
A new Slate project comes with a `.gitignore` file. This file is useful if you plan on using `git` for version control as it contains a list of files and folders to be ignored when committing to a git repository. Ignored files are both Slate project specific files as well as commonly ignored files on any project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - instances of git and "git" with Git

@NathanPJF NathanPJF merged commit 985df89 into master Jul 19, 2017
@NathanPJF NathanPJF deleted the docs-new-getting-started branch July 19, 2017 22:13
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants