Update vendor js build

[macdonaldr93]

@Shopify/themes-fed

Updating this build so that we can control the order that vendors get included. Also, added uglify. Doesn't seem to affect the length of time build takes that heavily, also, it would only run on watch if vendor.js was updated so I think it's fine.

Uglify will remove all comments except for license comments. We can leverage this to keep comments in the file if we want by doing: /*! lodash.core.min.js */.

I would like to bring this over to Debut.

[cshold]

Add a comment into vendor.js that says the /* filename */ syntax is for keeping comments, otherwise I have no idea what's going on.

From a dev perspective, not running it on watch means if you ever add a vendor you have to restart your tasks. I'd rather have the uglification and upload take longer than it not happen at all. Thoughts?

[macdonaldr93]

Added a comment that explains how the comment preservation works.

And yeah, like simply adding a file to the vendor folder won't trigger a rebuild; only updating vendor.js will. So I would agree with you, I'd rather it always happen and just take longer.

[cshold]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.