This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fixes #96
current_variant
information so the initial prices displayed reflect the option selectors.New stuff:
The changes in
product.js
have to do with how we are handling compare_at information when the variant is on sale. We are always leaving the "compare_at" text on screen for screenreaders, even when we were hiding the sale price. Now it hides that text if the variant isn't on sale.I also update the strikethrough price when the variant isn't on sale. It was already being hidden with the
hide
class, but it just felt odd to leave a strikethrough price in the markup if we had no intention of using it./cc @Shopify/themes-fed
Checklist
For contributors:
For maintainers:
package.json
version in a separate PR, if applicable.